big refactor and testing

agent/disk/disk_test.go

@@ -0,0 +1,51 @@
+package disk_test
+
+import (
+	"errors"
+	"fmt"
+	"testing"
+
+	"github.com/amidaware/rmmagent/agent/disk"
+)
+
+func TestGetDisks(t *testing.T) {
+	exampleDisk := disk.Disk{
+		Device:  "C:",
+		Fstype:  "NTFS",
+		Total:   "149.9 GB",
+		Used:    "129.2 GB",
+		Free:    "20.7 GB",
+		Percent: 86,
+	}
+
+	testTable := []struct {
+		name          string
+		expected      []disk.Disk
+		atLeast       int
+		expectedError error
+	}{
+		{
+			name:          "Get Disks",
+			expected:      []disk.Disk{exampleDisk},
+			atLeast:       1,
+			expectedError: nil,
+		},
+	}
+
+	for _, tt := range testTable {
+		t.Run(tt.name, func(t *testing.T) {
+			result, err := disk.GetDisks()
+			if fmt.Sprintf("%T", result) != "[]disk.Disk" {
+				t.Errorf("expected type %T, got type %T", tt.expected, result)
+			}
+
+			if !errors.Is(err, tt.expectedError) {
+				t.Errorf("expected error (%v), got error(%v)", tt.expectedError, err)
+			}
+
+			if len(result) < 1 {
+				t.Errorf("expected count at least %d, got %d", tt.atLeast, len(result))
+			}
+		})
+	}
+}