From 75e6d3240f186ce715668eaa3c66485900fdd9f4 Mon Sep 17 00:00:00 2001 From: redanthrax Date: Tue, 28 Jun 2022 15:27:11 -0700 Subject: [PATCH] remove logf to clean up tests output --- agent/agent_test.go | 8 +------- agent/disk/disk_test.go | 1 - agent/network/network_test.go | 1 - agent/patching/patching_test.go | 3 +-- agent/software/software_test.go | 1 - agent/system/system_darwin_test.go | 2 -- agent/system/system_linux_test.go | 4 +--- agent/system/system_unix_test.go | 8 +------- agent/umi/umi_unix_test.go | 1 - agent/utils/utils_test.go | 1 - 10 files changed, 4 insertions(+), 26 deletions(-) diff --git a/agent/agent_test.go b/agent/agent_test.go index aa0aac8..8802576 100644 --- a/agent/agent_test.go +++ b/agent/agent_test.go @@ -17,17 +17,13 @@ func TestGetDisks(t *testing.T) { if len(disks) < 1 { t.Errorf("Could not get disks") } - - t.Logf("Result: %v", disks) } func TestSystemRebootRequired(t *testing.T) { - result, err := a.SystemRebootRequired() + _, err := a.SystemRebootRequired() if err != nil { t.Error(err) } - - t.Logf("Result: %t", result) } func TestLoggedOnUser(t *testing.T) { @@ -35,6 +31,4 @@ func TestLoggedOnUser(t *testing.T) { if result == "" { t.Errorf("Could not get logged on user.") } - - t.Logf("Result: %s", result) } diff --git a/agent/disk/disk_test.go b/agent/disk/disk_test.go index 0ac7c68..b03e591 100644 --- a/agent/disk/disk_test.go +++ b/agent/disk/disk_test.go @@ -26,7 +26,6 @@ func TestGetDisks(t *testing.T) { for _, tt := range testTable { t.Run(tt.name, func(t *testing.T) { result, err := disk.GetDisks() - t.Logf("Result: (%v)", result) if fmt.Sprintf("%T", result) != "[]disk.Disk" { t.Errorf("expected type %T, got type %T", tt.expected, result) } diff --git a/agent/network/network_test.go b/agent/network/network_test.go index 18673c8..1391ecc 100644 --- a/agent/network/network_test.go +++ b/agent/network/network_test.go @@ -22,7 +22,6 @@ func TestPublicIP(t *testing.T) { for _, tt := range testTable { t.Run(tt.name, func(t *testing.T) { result := network.PublicIP(tt.proxy) - t.Logf("result: (%v)", result) if result != tt.expected { t.Errorf("expected %s, got %s", tt.expected, result) } diff --git a/agent/patching/patching_test.go b/agent/patching/patching_test.go index 29a9ae0..4451f2d 100644 --- a/agent/patching/patching_test.go +++ b/agent/patching/patching_test.go @@ -48,8 +48,7 @@ func TestGetUpdates(t *testing.T) { for _, tt := range testTable { t.Run(tt.name, func(t *testing.T) { - result, err := patching.GetUpdates() - t.Logf("result: (%v)", result) + _, err := patching.GetUpdates() if !errors.Is(tt.expectedError, err) { t.Errorf("expected (%v), got (%v)", tt.expectedError, err) } diff --git a/agent/software/software_test.go b/agent/software/software_test.go index 55ca1d0..6672516 100644 --- a/agent/software/software_test.go +++ b/agent/software/software_test.go @@ -25,7 +25,6 @@ func TestGetInstalledSoftware(t *testing.T) { for _, tt := range testTable { t.Run(tt.name, func(t *testing.T) { result, err := software.GetInstalledSoftware() - t.Logf("result: (%v)", result) if len(result) < tt.atLeast { t.Errorf("expected at least %d, got %d", tt.atLeast, len(result)) } diff --git a/agent/system/system_darwin_test.go b/agent/system/system_darwin_test.go index 4e7c126..8093d09 100644 --- a/agent/system/system_darwin_test.go +++ b/agent/system/system_darwin_test.go @@ -22,6 +22,4 @@ func TestRunScript(t *testing.T) { if exitcode != 0 { t.Fatalf("Error: Exit Code %d", exitcode) } - - t.Logf("Result: %s", stdout) } diff --git a/agent/system/system_linux_test.go b/agent/system/system_linux_test.go index 5f271b4..aef14f1 100644 --- a/agent/system/system_linux_test.go +++ b/agent/system/system_linux_test.go @@ -10,7 +10,7 @@ import ( ) func TestRunScript(t *testing.T) { - stdout, stderr, exitcode, err := system.RunScript("#!/bin/sh\ncat /etc/os-release", "/bin/sh", nil, 30) + _, stderr, exitcode, err := system.RunScript("#!/bin/sh\ncat /etc/os-release", "/bin/sh", nil, 30) if err != nil { t.Fatal(err) } @@ -22,6 +22,4 @@ func TestRunScript(t *testing.T) { if exitcode != 0 { t.Fatalf("Error: Exit Code %d", exitcode) } - - t.Logf("Result: %s", stdout) } diff --git a/agent/system/system_unix_test.go b/agent/system/system_unix_test.go index d9fa548..35eb52f 100644 --- a/agent/system/system_unix_test.go +++ b/agent/system/system_unix_test.go @@ -22,8 +22,6 @@ func TestSystemRebootRequired(t *testing.T) { if err != nil { t.Fatal(err) } - - t.Logf("System Reboot Required %t", required) } func TestShowStatus(t *testing.T) { @@ -41,8 +39,6 @@ func TestLoggedOnUser(t *testing.T) { if user == "" { t.Fatalf("Expected a user, got empty") } - - t.Logf("Logged on user: %s", user) } func TestOsString(t *testing.T) { @@ -50,6 +46,4 @@ func TestOsString(t *testing.T) { if osString == "error getting host info" { t.Fatalf("Unable to get OS string") } - - t.Logf("OS String: %s", osString) -} \ No newline at end of file +} diff --git a/agent/umi/umi_unix_test.go b/agent/umi/umi_unix_test.go index 4c21714..3873ad7 100644 --- a/agent/umi/umi_unix_test.go +++ b/agent/umi/umi_unix_test.go @@ -25,7 +25,6 @@ func TestGetInfo(t *testing.T) { for _, tt := range testTable { t.Run(tt.name, func(t *testing.T) { result, _ := umi.GetInfo() - t.Logf("result: (%v)", result) if len(result) < tt.atLeast { t.Errorf("expected at least %d, got %d", tt.atLeast, len(result)) } diff --git a/agent/utils/utils_test.go b/agent/utils/utils_test.go index 68c734c..e8e33f1 100644 --- a/agent/utils/utils_test.go +++ b/agent/utils/utils_test.go @@ -32,7 +32,6 @@ func TestByteCountSI(t *testing.T) { for _, tt := range testTable { t.Run(tt.name, func(t *testing.T) { result := utils.ByteCountSI(tt.bytes) - t.Logf("result: (%v)", result) if result != tt.expected { t.Errorf("expected %s, got %s", tt.expected, result) }